Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One-HyeWon
approved these changes
Nov 13, 2024
| }; | ||
| }; | ||
|
|
||
| export default function PostImages({ post }: Props) { | ||
| if (!post?.Images || post?.Images.length === 0) return null; | ||
| if (!post?.images || post?.images.length === 0) return null; |
There was a problem hiding this comment.
이미지가 없는 경우에 대한 ui 반응은 따로 없는 건가요?
There was a problem hiding this comment.
이미지가 없는 경우는 PostImage 컴포넌트가 안떠서 Post 컴포넌트에 그냥 글만 뜨게 되어 있어요!
One-HyeWon
approved these changes
Nov 14, 2024
| }; | ||
| }; | ||
|
|
||
| export default function PostImages({ post }: Props) { | ||
| if (!post?.Images || post?.Images.length === 0) return null; | ||
| if (!post?.images || post?.images.length === 0) return null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
포스트에서 api response를 처리할 때 데이터 구조가 잘못 되어 있어서 이미지 url을 받아오지 못했습니다.
이를 수정하여 이미지를 불러올 수 있도록 고쳤습니다.